Skip to content

Conversation

@Demogorgon314
Copy link
Member

PIP: PIP-380 #23304

Motivation

#23304

Modifications

Add a new configuration loadBalancerSheddingExcludedNamespaces to allow disabling the load balancer shedding for specific namespaces.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 self-assigned this Nov 4, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Nov 4, 2024
@Demogorgon314 Demogorgon314 marked this pull request as ready for review November 8, 2024 01:00
Copy link
Contributor

@heesung-sohn heesung-sohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments. otherwise LGTM.

@heesung-sohn
Copy link
Contributor

@Demogorgon314
Copy link
Member Author

@heesung-sn Updated. PTAL again.

@heesung-sohn
Copy link
Contributor

LGTM

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-380-Support-setting-up-specific-namespaces-to-skipping-the-load-shedding-impl branch from f1729e0 to bb1ab6c Compare December 13, 2024 12:58
@Demogorgon314 Demogorgon314 requested a review from shibd February 20, 2025 09:31
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-380-Support-setting-up-specific-namespaces-to-skipping-the-load-shedding-impl branch from bb1ab6c to 25e2580 Compare June 4, 2025 02:03
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (bbc6224) to head (ca29336).
Report is 1137 commits behind head on master.

Files with missing lines Patch % Lines
...roker/loadbalance/impl/ModularLoadManagerImpl.java 47.82% 9 Missing and 3 partials ⚠️
...ker/loadbalance/extensions/models/TopKBundles.java 71.42% 1 Missing and 1 partial ⚠️
...dbalance/extensions/ExtensibleLoadManagerImpl.java 88.88% 0 Missing and 1 partial ⚠️
...dbalance/extensions/scheduler/TransferShedder.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23549      +/-   ##
============================================
+ Coverage     73.57%   74.28%   +0.70%     
+ Complexity    32624    32324     -300     
============================================
  Files          1877     1868       -9     
  Lines        139502   145319    +5817     
  Branches      15299    16623    +1324     
============================================
+ Hits         102638   107943    +5305     
+ Misses        28908    28833      -75     
- Partials       7956     8543     +587     
Flag Coverage Δ
inttests 26.84% <41.66%> (+2.26%) ⬆️
systests 23.26% <25.00%> (-1.06%) ⬇️
unittests 73.78% <66.66%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 98.16% <100.00%> (-1.23%) ⬇️
...ns/strategy/RoundRobinBrokerSelectionStrategy.java 100.00% <100.00%> (ø)
...dbalance/extensions/ExtensibleLoadManagerImpl.java 79.57% <88.88%> (-0.52%) ⬇️
...dbalance/extensions/scheduler/TransferShedder.java 82.51% <80.00%> (-0.41%) ⬇️
...ker/loadbalance/extensions/models/TopKBundles.java 93.75% <71.42%> (+2.96%) ⬆️
...roker/loadbalance/impl/ModularLoadManagerImpl.java 83.25% <47.82%> (-1.73%) ⬇️

... and 1079 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BewareMyPower BewareMyPower merged commit 0f9ea18 into apache:master Jun 10, 2025
53 checks passed
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required Your PR changes impact docs and you will update later. ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants