-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][broker] PIP-380: Support-setting-up-specific-namespaces-to-skipping-the-load-shedding #23549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
heesung-sohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor comments. otherwise LGTM.
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java
Outdated
Show resolved
Hide resolved
...r-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
|
btw, we probably want to add this bundle load data filtering logic here as well, |
|
@heesung-sn Updated. PTAL again. |
|
LGTM |
f1729e0 to
bb1ab6c
Compare
bb1ab6c to
25e2580
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23549 +/- ##
============================================
+ Coverage 73.57% 74.28% +0.70%
+ Complexity 32624 32324 -300
============================================
Files 1877 1868 -9
Lines 139502 145319 +5817
Branches 15299 16623 +1324
============================================
+ Hits 102638 107943 +5305
+ Misses 28908 28833 -75
- Partials 7956 8543 +587
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…skipping-the-load-shedding (apache#23549)
…skipping-the-load-shedding (apache#23549)
PIP: PIP-380 #23304
Motivation
#23304
Modifications
Add a new configuration
loadBalancerSheddingExcludedNamespacesto allow disabling the load balancer shedding for specific namespaces.Documentation
docdoc-requireddoc-not-neededdoc-complete