Skip to content

Remove documentation for older versions of testcontainers-java#37719

Merged
terrymanu merged 1 commit intoapache:masterfrom
linghengqian:fix-doc
Jan 12, 2026
Merged

Remove documentation for older versions of testcontainers-java#37719
terrymanu merged 1 commit intoapache:masterfrom
linghengqian:fix-doc

Conversation

@linghengqian
Copy link
Member

@linghengqian linghengqian commented Jan 12, 2026

Fixes #37642 .

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@linghengqian linghengqian marked this pull request as ready for review January 12, 2026 11:19
@linghengqian linghengqian added this to the 5.5.3 milestone Jan 12, 2026
@linghengqian linghengqian requested a review from Copilot January 12, 2026 11:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes outdated Docker configuration requirements related to older versions of testcontainers-java. The changes simplify Docker daemon setup instructions by removing the minimum API version constraint that is no longer needed.

Changes:

  • Remove "min-api-version": "1.24" from Docker daemon configuration examples in documentation

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.en.md Remove Docker API version constraint from proxy startup documentation (English)
docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.cn.md Remove Docker API version constraint from proxy startup documentation (Chinese)
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.en.md Remove Docker API version constraint from JDBC development documentation (English)
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.cn.md Remove Docker API version constraint from JDBC development documentation (Chinese)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terrymanu terrymanu merged commit 1149470 into apache:master Jan 12, 2026
18 checks passed
@linghengqian linghengqian deleted the fix-doc branch January 12, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supports running nativeTest on the master branch on Docker Engine v29

3 participants