Skip to content

Comments

Fix failing nativeTest on Windows Server 2025#37775

Merged
RaigorJiang merged 1 commit intoapache:masterfrom
linghengqian:windows-server
Jan 20, 2026
Merged

Fix failing nativeTest on Windows Server 2025#37775
RaigorJiang merged 1 commit intoapache:masterfrom
linghengqian:windows-server

Conversation

@linghengqian
Copy link
Member

@linghengqian linghengqian commented Jan 19, 2026

Fixes #37642 .

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@linghengqian linghengqian force-pushed the windows-server branch 2 times, most recently from bcd4409 to 1476172 Compare January 19, 2026 15:12
@linghengqian linghengqian requested a review from Copilot January 19, 2026 16:17
@linghengqian linghengqian marked this pull request as ready for review January 19, 2026 16:18
@linghengqian linghengqian added this to the 5.5.4 milestone Jan 19, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a temporary workaround to fix failing native tests on Windows Server 2025 by setting the Docker API version to 1.44. This addresses compatibility issues between testcontainers 2.0.3 (which requires Docker Engine v29+) and the current version of Rancher Desktop (which bundles Docker Engine v28). The fix will be superseded once a new Rancher Desktop release incorporating rancher-sandbox/rancher-desktop/pull/9724 becomes available.

Changes:

  • Added DOCKER_API_VERSION=1.44 environment variable setting to CI scripts and documentation
  • Updated both English and Chinese documentation files with the workaround instructions

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/native/src/test/resources/test-native/ps1/config-rdctl.ps1 Added Docker API version environment variable setting to the CI configuration script for Windows Server
docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.en.md Updated English documentation with Docker API version workaround for Windows users
docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.cn.md Updated Chinese documentation with Docker API version workaround for Windows users
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.en.md Updated English development documentation with Docker API version workaround for both Windows 11 and Windows Server 2025 scenarios
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.cn.md Updated Chinese development documentation with Docker API version workaround for both Windows 11 and Windows Server 2025 scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RaigorJiang RaigorJiang merged commit de7710d into apache:master Jan 20, 2026
23 checks passed
@linghengqian linghengqian deleted the windows-server branch January 20, 2026 06:45
@RaigorJiang RaigorJiang modified the milestones: 5.5.4, 5.5.3 Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supports running nativeTest on the master branch on Docker Engine v29

2 participants