Skip to content

Conversation

@wankai123
Copy link
Member

@wankai123 wankai123 commented Dec 2, 2025

@wankai123 wankai123 added this to the 10.4.0 milestone Dec 2, 2025
@wankai123 wankai123 added bug Something isn't working and you are sure it's a bug! protocol agent->collector or UI->collector protocols related. labels Dec 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Cumulative Layout Shift (CLS) metric handling in the browser performance monitoring system by renaming clsTime to cls and changing its type from integer to double. CLS is a unitless score (not a time measurement), so the change aligns the field name and type with the metric's actual nature.

  • Renamed field from clsTime to cls across the codebase
  • Changed CLS type from int to double to properly represent the decimal score
  • Added conversion logic to scale CLS by 1000 before storing as integer

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
BrowserWebVitalsPerfDataAnalysisListener.java Updated to call getCls() and multiply by 1000 before storing as int
BrowserWebVitalsPerfDataDecorator.java Changed getter method from getClsTime() returning int to getCls() returning double
BrowserAppWebVitalsPerf.java Renamed field from clsTime to cls
changes.md Added changelog entry documenting the fix
browser-protocol.md Updated documentation example showing CLS as 0.1 instead of 10
apm-network/src/main/proto Updated subproject commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@wu-sheng
Copy link
Member

wu-sheng commented Dec 2, 2025

Agent side code mergrd. We should update e2e for it?

wu-sheng
wu-sheng previously approved these changes Dec 3, 2025
@wu-sheng wu-sheng merged commit c5eb6bd into apache:master Dec 3, 2025
351 of 353 checks passed
@wankai123 wankai123 deleted the browser branch December 3, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working and you are sure it's a bug! protocol agent->collector or UI->collector protocols related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] com.google.protobuf.InvalidProtocolBufferException: Not an int32 value

2 participants