-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-54982][INFRA] Use ASF_NEXUS_TOKEN to release and drop staging repository when finalizing the RC #53744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
59f3fcc to
297db63
Compare
JIRA Issue Information=== Bug SPARK-54982 === This comment was automatically generated by GitHub Actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Are you going to document how to get Nexus token in our website after this PR?
Nice, I saw both PRs and approved.
|
Merged to master, branch-4.1, branch-4.0 and branch-3.5. |
…repository when finalizing the RC ### What changes were proposed in this pull request? This PR proposes to use ASF_NEXUS_TOKEN to release and drop staging repository when finalizing the RC. While I am here, I made the commands more portable/universal - in practice, I wanted to use the same commands when I test in my local. ### Why are the changes needed? To automatically release/drop the staging repo. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? I manually tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53744 from HyukjinKwon/minor-compat-command. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit c26a3e4) Signed-off-by: Hyukjin Kwon <[email protected]>
…repository when finalizing the RC This PR proposes to use ASF_NEXUS_TOKEN to release and drop staging repository when finalizing the RC. While I am here, I made the commands more portable/universal - in practice, I wanted to use the same commands when I test in my local. To automatically release/drop the staging repo. No, dev-only. I manually tested. No. Closes #53744 from HyukjinKwon/minor-compat-command. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit c26a3e4) Signed-off-by: Hyukjin Kwon <[email protected]>
…repository when finalizing the RC This PR proposes to use ASF_NEXUS_TOKEN to release and drop staging repository when finalizing the RC. While I am here, I made the commands more portable/universal - in practice, I wanted to use the same commands when I test in my local. To automatically release/drop the staging repo. No, dev-only. I manually tested. No. Closes #53744 from HyukjinKwon/minor-compat-command. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
…finalizing the RC Per apache/spark#53744 Author: Hyukjin Kwon <[email protected]> Closes #659 from HyukjinKwon/release-automation.
…repository when finalizing the RC ### What changes were proposed in this pull request? This PR proposes to use ASF_NEXUS_TOKEN to release and drop staging repository when finalizing the RC. While I am here, I made the commands more portable/universal - in practice, I wanted to use the same commands when I test in my local. ### Why are the changes needed? To automatically release/drop the staging repo. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? I manually tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53744 from HyukjinKwon/minor-compat-command. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
|
|
||
| # Release the repository | ||
| curl --retry 10 --retry-all-errors -s -u "$APACHE_USERNAME:$APACHE_PASSWORD" \ | ||
| curl --retry 10 --retry-all-errors -s -u "$ASF_USERNAME:$ASF_NEXUS_TOKEN" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @HyukjinKwon .
For me, ASF_NEXUS_TOKEN has two fields, xxx:yyy (Name Code: Pass Code), style. I'm wondering if you change ASF_USERNAME here with Name Code? Nesus repository shows like the following.
<server>
<id>${server}</id>
<username>xxx</username>
<password>yyy</password>
</server>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change ASF_USERNAME to Name Code, does the other release process work for you? For example, the following seems to be broken.
dev/create-release/release-build.sh: echo "From: [email protected]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah password only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
username is just username as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should clarify it .. let me open a PR to fix. ASF_USERNAME is username (mine is gurwls223 for example). ASF_NEXUS_TOKEN is yyy at password.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I tried it with username combination and it did not work for me. in short,
-u xxx:yyydid not work for me-u gurwls223:mypassworddid not work.-u gurwls223:yyyworked for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thank you for clarifying. Let me try Spark 3.5.8 with that style . :)
What changes were proposed in this pull request?
This PR proposes to use ASF_NEXUS_TOKEN to release and drop staging repository when finalizing the RC.
While I am here, I made the commands more portable/universal - in practice, I wanted to use the same commands when I test in my local.
Why are the changes needed?
To automatically release/drop the staging repo.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
I manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.