Feat : support MilvusSink dev #3559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
dominikriemer
requested changes
Apr 8, 2025
Member
dominikriemer
left a comment
dominikriemer
left a comment
There was a problem hiding this comment.
Thanks a lot for your PR! I added some suggestions how to improve the PR before merging it.
| IndexParam indexParam; | ||
| CreateCollectionReq.CollectionSchema collectionSchema; | ||
|
|
||
| public static final String BYTE = "http://www.w3.org/2001/XMLSchema#byte"; |
Member
There was a problem hiding this comment.
There is an Xsd class in org.apache.streampipes.vocabulary which provide these variables, could you reuse these?
| client.createDatabase(createDatabaseReq); | ||
| client.useDatabase(dbName); | ||
| } catch (Exception ignored) { | ||
| //todo add log |
Member
There was a problem hiding this comment.
Can you add some logging here? You can throw a SpRuntimeException so that any problems when creating the database connection will show up in the UI.
| DescribeCollectionReq describeCollectionReq = DescribeCollectionReq.builder() | ||
| .collectionName(this.collectionName) | ||
| .build(); | ||
| System.out.println("collection name" + this.collectionName); |
Member
There was a problem hiding this comment.
System.out can be replaced by logging
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestions! I will use these suggestions to modify my code.
dominikriemer
approved these changes
Apr 9, 2025
Contributor
|
@Yuukadesu thanks a lot for your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
support MilvusSink ,and this Sink support FloatVector and BinaryVector now
Remarks
PR introduces (a) breaking change(s): <yes/no>
PR introduces (a) deprecation(s): <yes/no>