chore(plugin-chart-echarts): upgrade to echarts 5.4.1#22382
Merged
villebro merged 1 commit intoapache:masterfrom Dec 10, 2022
Merged
chore(plugin-chart-echarts): upgrade to echarts 5.4.1#22382villebro merged 1 commit intoapache:masterfrom
villebro merged 1 commit intoapache:masterfrom
Conversation
villebro
force-pushed
the
villebro/echarts-5.4.1
branch
from
ea3d241 to
c483904
Compare
Member
|
/testenv up |
Contributor
|
@zhaoyongjie Ephemeral environment spinning up at http://35.93.30.108:8080. Credentials are |
zhaoyongjie
approved these changes
Dec 10, 2022
Member
zhaoyongjie
left a comment
zhaoyongjie
left a comment
There was a problem hiding this comment.
Tested and LGTM. Thanks for the fixing.
Codecov Report
@@ Coverage Diff @@
## master #22382 +/- ##
=======================================
Coverage 66.86% 66.86%
=======================================
Files 1847 1847
Lines 70567 70567
Branches 7744 7744
=======================================
Hits 47184 47184
Misses 21382 21382
Partials 2001 2001
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
This was referenced Jan 3, 2023
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bump ECharts to 5.4.1. Changelog: https://echarts.apache.org/en/changelog.html
More specifically for Superset, this patch release fixes an issue that @zhaoyongjie spotted in this review commen: #22218 (comment) (link to original fix PR: apache/echarts#17715)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION