Skip to content

chore(ci): update Node.js version used in building CI image#38635

Open
hainenber wants to merge 6 commits intomasterfrom
chore/update-node-in-ci-image-building
Open

chore(ci): update Node.js version used in building CI image#38635
hainenber wants to merge 6 commits intomasterfrom
chore/update-node-in-ci-image-building

Conversation

@hainenber
Copy link
Contributor

@hainenber hainenber commented Mar 13, 2026

User description

chore(ci): update Node.js version used in building CI image + sync lockfile

SUMMARY

A very chore PR to get Node.js runtime version used for building CI image on par with .nvmrc, which is Node22 already.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Green CI as acceptance threshold

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CodeAnt-AI Description

Align CI build Node runtime with local development and fix a test that broke under the newer runtime

What Changed

  • CI image now uses Node 22 for building frontend assets, matching the project's configured Node version
  • A JSON validation test expectation was adjusted so error column is reported as 1 instead of 0, preventing a false test failure under Node 22

Impact

✅ CI builds use the same Node runtime as local development
✅ Tests pass consistently under Node 22
✅ Fewer CI false negatives due to runtime differences

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

…ckfile

Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 13, 2026

Code Review Agent Run #757279

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 0fc9050..0fc9050
    • Dockerfile
  • Files skipped - 1
    • superset-frontend/package-lock.json - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Signed-off-by: hainenber <dotronghai96@gmail.com>
@dosubot dosubot bot added the infra Namespace | Anything related to infrastructure label Mar 13, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 13, 2026

Code Review Agent Run #bd834e

Actionable Suggestions - 0
Additional Suggestions - 1
  • superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/useJsonValidation.test.ts - 1
    • Incorrect test expectation · Line 63-63
      The test expects column: 1, but the useJsonValidation hook defaults to column: 0 when no line/column info is present in the JSON parse error message. This mismatch will cause the test to fail.
      Code suggestion
       @@ -60,7 +60,7 @@
      -     expect(result.current[0]).toMatchObject({
      -       type: 'error',
      -       row: 0,
      -       column: 1,
      -       text: expect.stringContaining('Invalid JSON'),
      -     });
      -   });
      +     expect(result.current[0]).toMatchObject({
      +       type: 'error',
      +       row: 0,
      +       column: 0,
      +       text: expect.stringContaining('Invalid JSON'),
      +     });
      +   });
Review Details
  • Files reviewed - 1 · Commit Range: 0fc9050..be76eaf
    • superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/useJsonValidation.test.ts
  • Files skipped - 1
    • superset-frontend/package-lock.json - Reason: Filter setting
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Mar 14, 2026
@codeant-ai-for-open-source codeant-ai-for-open-source bot added size:XS This PR changes 0-9 lines, ignoring generated files and removed size:XS This PR changes 0-9 lines, ignoring generated files labels Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Namespace | Anything related to infrastructure packages size/XS size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant