Skip to content

fix(FilterBar): reduce padded space between filter header and first filter#38646

Open
hainenber wants to merge 2 commits intomasterfrom
fix/reduce-excessive-space-betweenf-tiler-header-and-first-filter
Open

fix(FilterBar): reduce padded space between filter header and first filter#38646
hainenber wants to merge 2 commits intomasterfrom
fix/reduce-excessive-space-betweenf-tiler-header-and-first-filter

Conversation

@hainenber
Copy link
Contributor

@hainenber hainenber commented Mar 14, 2026

User description

fix(FilterBar): reduce padded space between filter header and first filter

SUMMARY

Fixes #38600

Reduces ~24px of space buffering filter header and first filter. All modified components are of Vertical type so no changes to Horizontal mode.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CodeAnt-AI Description

Reduce excessive vertical gap between filter header and first filter in vertical filter bar

What Changed

  • Removed extra bottom/top padding so the header sits closer to the first filter in vertical filter bars
  • Reduced overall top padding in the filter panel wrapper so content starts higher without affecting horizontal mode
  • Visual spacing between header and first filter decreased by ~24px in vertical layout

Impact

✅ Less empty space in filter panels
✅ Shorter vertical filter bars on dashboards
✅ Clearer, tighter filter layout

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

…ilter

Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 14, 2026

Code Review Agent Run #a3135c

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: ad5fa34..ad5fa34
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added change:frontend Requires changing the frontend dashboard:native-filters Related to the native filters of the Dashboard labels Mar 14, 2026
@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Mar 14, 2026
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

This PR reduces the visual gap between the filter bar header and the first filter in vertical mode. It does this by removing header bottom padding and filter list top padding while leaving horizontal behavior unchanged.

sequenceDiagram
    participant User
    participant DashboardUI
    participant Header
    participant FilterList

    User->>DashboardUI: Open dashboard with vertical filter bar
    DashboardUI->>Header: Render header with bottom padding removed
    DashboardUI->>FilterList: Render filter controls with top padding removed
    DashboardUI->>DashboardUI: Keep horizontal mode layout unchanged
    DashboardUI-->>User: Header and first filter appear closer together
Loading

Generated by CodeAnt AI

Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 14, 2026

Code Review Agent Run #b23150

Actionable Suggestions - 0
Additional Suggestions - 1
  • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx - 1
    • Time-specific comment with typo · Line 122-122
      The comment references a specific PR, which is time-specific and may become outdated, violating the guideline to write timeless comments. Additionally, there's a grammatical error ("reduces" should be "reduce").
      Code suggestion
      --- superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
      +++ superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
       @@ -122,1 +122,1 @@
      -    padding-top: 0; /* Works with other changes in PR https://github.com/apache/superset/pull/38646 to reduces space between filter header and 1st filter */
      +    padding-top: 0; /* Reduces space between filter header and first filter */
Review Details
  • Files reviewed - 2 · Commit Range: ad5fa34..09951dd
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx
    • superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend dashboard:native-filters Related to the native filters of the Dashboard size/XS size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6.1.0rc1 - Excessive space between filters header and first filter

1 participant