-
Notifications
You must be signed in to change notification settings - Fork 440
TEZ-4674: Update Dockerfile dependencies: Protobuf 3.25.5, and stable Python, npm tools #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(!) A patch to the testing environment has been detected. |
… Python, npm tools
|
🎊 +1 overall
This message was automatically generated. |
408f016 to
2a86d50
Compare
|
(!) A patch to the testing environment has been detected. |
| && make install | ||
| WORKDIR /root | ||
| RUN rm -rf /opt/protobuf-src | ||
| https://github.com/protocolbuffers/protobuf/releases/download/v25.5/protoc-25.5-linux-x86_64.zip \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Protobuf removed Autotools (./configure and make). Wither we use CMake or Bazel to build from source or directly download the protoc which is also available on release page.
- URL & Versioning: The version numbering scheme changed. What was previously v3.21.x is now v25.x. The URL pattern and tarball names have changed accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change looks good, compiling protobuf from source is an overkill if there is a binary available
|
🎊 +1 overall
This message was automatically generated. |
|
change looks good to me, good improvement to the Dockerfile, +1 |
impwhich has been marked deprecated sincepython-3.4