Skip to content

Conversation

@Aggarwal-Raghav
Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav commented Jan 18, 2026

  1. pylint is not running because of the missing dependency of imp which has been marked deprecated since python-3.4
  2. protobuf is running with older version 3.21. we need to move to 3.25.5 as same as pom.xml

@tez-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-452/1/console in case of problems.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 5m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 codespell 0m 5s No new issues.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 0s No new issues.
+1 💚 shellcheck 0m 0s No new issues.
_ Other Tests _
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
6m 42s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-452/1/artifact/out/Dockerfile
GITHUB PR #452
Optional Tests dupname asflicense codespell detsecrets hadolint shellcheck shelldocs
uname Linux 35ef9d125373 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-452/src/.yetus/personality.sh
git revision master / 408f016
Max. process+thread count 53 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-452/1/console
versions git=2.43.0 maven=3.8.7 hadolint=1.18.0-0-g76eee5c codespell=2.4.1 shellcheck=0.7.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-452/2/console in case of problems.

&& make install
WORKDIR /root
RUN rm -rf /opt/protobuf-src
https://github.com/protocolbuffers/protobuf/releases/download/v25.5/protoc-25.5-linux-x86_64.zip \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Protobuf removed Autotools (./configure and make). Wither we use CMake or Bazel to build from source or directly download the protoc which is also available on release page.
  2. URL & Versioning: The version numbering scheme changed. What was previously v3.21.x is now v25.x. The URL pattern and tarball names have changed accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good, compiling protobuf from source is an overkill if there is a binary available

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 codespell 0m 5s No new issues.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 0s No new issues.
+1 💚 shellcheck 0m 0s No new issues.
_ Other Tests _
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
3m 19s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-452/2/artifact/out/Dockerfile
GITHUB PR #452
Optional Tests dupname asflicense codespell detsecrets hadolint shellcheck shelldocs
uname Linux 8b83eb15d386 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-452/src/.yetus/personality.sh
git revision master / 2a86d50
Max. process+thread count 53 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-452/2/console
versions git=2.43.0 maven=3.8.7 hadolint=1.18.0-0-g76eee5c codespell=2.4.1 shellcheck=0.7.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog self-requested a review January 19, 2026 08:10
@abstractdog
Copy link
Contributor

change looks good to me, good improvement to the Dockerfile, +1
pending github actions

@abstractdog abstractdog merged commit faa9bb9 into apache:master Jan 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants