-
Notifications
You must be signed in to change notification settings - Fork 168
Description
Code of Conduct
- I agree to follow this project's Code of Conduct
Search before asking
- I have searched in the issues and found no similar issues.
What would you like to be improved?
Currently, when method checkBlockSendResult will only print error log like below:
org.apache.uniffle.common.exception.RssSendFailedException: Send failed: Task[7173_0] failed because 72 blocks can't be sent to shuffle server.
This is not enough. I think a more detailed version would be something like below:
org.apache.uniffle.common.exception.RssSendFailedException: Send failed: Task[7173_0] failed because 72 blocks can't be sent to shuffle server: [ShuffleServerInfo{id[127.0.0.1-19977-17000], host[127.0.0.1], grpc port[19977], netty port[17000]}].
Also, I think we don't need id in ShuffleServerInfo.toString, which I think is useless.
So the final output would be:
org.apache.uniffle.common.exception.RssSendFailedException: Send failed: Task[7173_0] failed because 72 blocks can't be sent to shuffle server: [ShuffleServerInfo{host[127.0.0.1], grpc port[19977], netty port[17000]}].
This is useful when troubleshooting.
How should we improve?
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!