[MINOR][IMPROVEMENT] Avoid CoordinatorServer#initialization multiple new Configuration()
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwangsheng
changed the title
jerqi
changed the title
jerqi
changed the title
new Configuration
jerqi
changed the title
new Configurationnew Configuration()
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
============================================
+ Coverage 57.11% 57.17% +0.05%
- Complexity 1199 1201 +2
============================================
Files 150 150
Lines 8176 8177 +1
Branches 773 773
============================================
+ Hits 4670 4675 +5
+ Misses 3259 3257 -2
+ Partials 247 245 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jerqi
approved these changes
Aug 3, 2022
Contributor
jerqi
left a comment
jerqi
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution. @zwangsheng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Useless multiple build Configuration
Why are the changes needed?
Reduce consumption
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test