[#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with yaml style remote client conf
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1722 +/- ##
============================================
- Coverage 54.86% 54.06% -0.80%
- Complexity 2358 2924 +566
============================================
Files 368 432 +64
Lines 16379 23356 +6977
Branches 1504 2187 +683
============================================
+ Hits 8986 12627 +3641
- Misses 6862 9951 +3089
- Partials 531 778 +247 ☔ View full report in Codecov by Sentry. |
Contributor
|
@zuston Could you commit this to branch 0.9? |
zuston
added a commit
that referenced
this pull request
May 22, 2024
…yaml style remote client conf (#1722) ### What changes were proposed in this pull request? fix classCastExpection of boolean->String with yaml style remote client conf ### Why are the changes needed? Fix: #1721 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit tests
Member
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix classCastExpection of boolean->String with yaml style remote client conf
Why are the changes needed?
Fix: #1721
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests