Skip to content

Conversation

@rickyma
Copy link
Contributor

@rickyma rickyma commented May 21, 2024

What changes were proposed in this pull request?

Introduce disks timeout metrics.

Why are the changes needed?

For #1728.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@rickyma
Copy link
Contributor Author

rickyma commented May 21, 2024

PTAL @zuston @jerqi

@github-actions
Copy link

Test Results

 2 405 files  ±0   2 405 suites  ±0   4h 57m 54s ⏱️ -33s
   931 tests ±0     930 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 791 runs  ±0  10 777 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit f7b7278. ± Comparison against base commit d9b1d9f.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zuston zuston merged commit d47ec22 into apache:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants