Skip to content

Conversation

@maobaolong
Copy link
Member

What changes were proposed in this pull request?

Fix docs yaml parse error about dashboard_guide.md

Why are the changes needed?

Just correct it.

Does this PR introduce any user-facing change?

Generate and view docs correctly.

How was this patch tested?

No need.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.76%. Comparing base (5ddcc28) to head (3218482).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1981      +/-   ##
============================================
- Coverage     52.77%   52.76%   -0.01%     
- Complexity     2498     2754     +256     
============================================
  Files           398      430      +32     
  Lines         18135    21754    +3619     
  Branches       1660     2057     +397     
============================================
+ Hits           9570    11479    +1909     
- Misses         7981     9514    +1533     
- Partials        584      761     +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maobaolong maobaolong closed this Jul 29, 2024
@maobaolong maobaolong reopened this Jul 29, 2024
@github-actions
Copy link

github-actions bot commented Jul 29, 2024

Test Results

 2 747 files  ±0   2 747 suites  ±0   5h 39m 54s ⏱️ + 1m 1s
   979 tests ±0     978 ✅ ±0   1 💤 ±0  0 ❌ ±0 
12 294 runs  ±0  12 279 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 3218482. ± Comparison against base commit 7c4be40.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@rickyma rickyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi changed the title [SMALLFIX] docs: Fix docs yaml parse error about dashboard_guide.md [MINOR] docs: Fix docs yaml parse error about dashboard_guide.md Jul 29, 2024
@zhengchenyu zhengchenyu merged commit 9f1e673 into apache:master Jul 30, 2024
@maobaolong
Copy link
Member Author

@rickyma @zhengchenyu Thanks for your review!

maobaolong added a commit to maobaolong/incubator-uniffle that referenced this pull request Aug 6, 2024
…che#1981)

### What changes were proposed in this pull request?

Fix docs yaml parse error about dashboard_guide.md

### Why are the changes needed?

Just correct it.

### Does this PR introduce _any_ user-facing change?

Generate and view docs correctly.

### How was this patch tested?

No need.

(cherry picked from commit 9f1e673)
zhengchenyu pushed a commit that referenced this pull request Aug 9, 2024
### What changes were proposed in this pull request?

Fix docs yaml parse error about dashboard_guide.md

### Why are the changes needed?

Just correct it.

### Does this PR introduce _any_ user-facing change?

Generate and view docs correctly.

### How was this patch tested?

No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants