[ISSUE-154][Improvement] Support Empty assignment to Shuffle Server #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat code style)
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=========================================
Coverage 61.21% 61.21%
Complexity 1506 1506
=========================================
Files 185 185
Lines 9360 9360
Branches 908 908
=========================================
Hits 5730 5730
Misses 3325 3325
Partials 305 305 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Nov 16, 2022
Contributor
jerqi
left a comment
jerqi
left a comment
There was a problem hiding this comment.
LGTM, it's awesome work. It really makes Uniffle better. We really appreciate that you can follow through the issues and raise a fix pr.
Contributor
|
Have you joined our |
Contributor
Author
|
@jerqi hhh , I'm already in the group. |
Member
|
Good job, I meet the same problem. @rhh777 . Thanks for your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow issue#154, When the RDD is Empty, partitionNum is 0, return the empty RssShuffleHandle directly
Why are the changes needed?
If the requested shuffle Server is 0, there is no need to request a coodinator.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT