UNOMI-784: use tasks to perform update_by_query and delete_by_query#636
Merged
UNOMI-784: use tasks to perform update_by_query and delete_by_query#636
Conversation
dgriffon
force-pushed
the
upgradeESSocketTimeout
branch
from
4568d85 to
9f9c10a
Compare
dgriffon
force-pushed
the
upgradeESSocketTimeout
branch
from
9f9c10a to
51e841d
Compare
jkevan
changed the title
sergehuber
reviewed
Jul 26, 2023
Contributor
sergehuber
left a comment
sergehuber
left a comment
There was a problem hiding this comment.
Hello Kevan,
Thank you for the contribution. I have added some comments to the review.
Best regards,
Serge...
...ain/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
Show resolved
Hide resolved
dgriffon
approved these changes
Jul 27, 2023
...ain/java/org/apache/unomi/persistence/elasticsearch/ElasticSearchPersistenceServiceImpl.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid SocketTimeoutError on long requests between Unomi and ES.
We will delegate to ES the work to do by using tasks system.