[YUNIKORN-3226] Remove event creation for succeeded / deleted pods#1001
Closed
manirajv06 wants to merge 2 commits intoapache:masterfrom
Closed
[YUNIKORN-3226] Remove event creation for succeeded / deleted pods#1001manirajv06 wants to merge 2 commits intoapache:masterfrom
manirajv06 wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
- Coverage 66.15% 66.09% -0.07%
==========================================
Files 72 72
Lines 7715 7713 -2
==========================================
- Hits 5104 5098 -6
- Misses 2398 2401 +3
- Partials 213 214 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Send event to the pods and nodes before deleting it.
Flows cleaned up based on the similar approach are
TaskFail,TaskCompletedandDecomissionNode.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3226
How should this be tested?
Existing tests should cover.
Screenshots (if appropriate)
Questions: