[YUNIKORN-3174] Read go mod to get the correct kubectl version#998
[YUNIKORN-3174] Read go mod to get the correct kubectl version#998pohanhuang wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
==========================================
+ Coverage 66.14% 66.19% +0.05%
==========================================
Files 72 72
Lines 7723 7723
==========================================
+ Hits 5108 5112 +4
+ Misses 2401 2398 -3
+ Partials 214 213 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- change the endpoint of kubectl downloading. Signed-off-by: hhcs9527 <hhcs9527@gmail.com>
1fd1f52 to
e93bc42
Compare
|
@chenyulin0719 should we update the default dev cluster with same setting as well? Line 74 in e93bc42 to K8S_VERSION :=$KUBECTL_VERSION
or
KUBECTL_VERSION=$(shell go list -m 'k8s.io/kubernetes' | cut -d' ' -f 2) |
chenyulin0719
left a comment
There was a problem hiding this comment.
Hi @pohanhuang, thanks for submitting this PR.
Regarding changing K8S_VERSION := v1.34.0 to match the Kubernetes version in mod.go, my only concern is that there is a small time gap between the Kubernetes release and the corresponding kind release. However, we usually upgrade the Kubernetes version only after a new kind version has been released. So I think it should be fine.
….34.0 Signed-off-by: hhcs9527 <hhcs9527@gmail.com>
|
Hi @chenyulin0719 , Please help review when you are avialable, thanks |
What is this PR for?
What type of PR is it?
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: