[YUNIKORN-3206] pod resource calculation incorrect with native sidecars#999
Closed
wilfred-s wants to merge 2 commits intoapache:masterfrom
Closed
[YUNIKORN-3206] pod resource calculation incorrect with native sidecars#999wilfred-s wants to merge 2 commits intoapache:masterfrom
wilfred-s wants to merge 2 commits intoapache:masterfrom
Conversation
Native sidecar containers are counted twice when calculation the maximum used resources during the init phase. If the pod has large init containers and small "real" containers the overall pod size will be incorrect. In most cases the init containers will be small and the issue will go undetected.
wilfred-s
requested review from
0yukali0,
craigcondit,
manirajv06,
mitdesai,
pbacsko and
yangwwei
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
- Coverage 66.16% 66.13% -0.04%
==========================================
Files 72 72
Lines 7723 7715 -8
==========================================
- Hits 5110 5102 -8
Misses 2399 2399
Partials 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manirajv06
requested changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Native sidecar containers are counted twice when calculation the maximum used resources during the init phase.
If the pod has large init containers and small "real" containers the overall pod size will be incorrect. In most cases the init containers will be small and the issue will go undetected.
What type of PR is it?
What is the Jira issue?
How should this be tested?
New unit tests added to check the speciifc use case