Subresource visited tracking is broken

[teohhanhui]

Basically the same as #1139. Previously fixed in #1144 and #1162.

Category

• children
• parent

Self-referencing resources results in infinite recursion leading to OOM.

Product

• brands
• isRelatedTo
• isSimilarTo

It tries to traverse deeper on the same path more than once, e.g.

[LogicException]
Route pattern "/products/{id}/is_related_to/{isRelatedTo}/is_related_to/{isRelatedTo}/brands.{_format}"
cannot reference variable name "isRelatedTo" more than once.

The expected behaviour is:

Product -[isRelatedTo]-> Product -[isRelatedTo] -> Product
                                 /  cut here  /

[soyuka]

Isn't this unit tested?

[teohhanhui]

The tests must be wrong then...

[soyuka]

https://github.com/api-platform/core/blob/master/tests/Bridge/Symfony/Routing/ApiLoaderTest.php#L232-L251

[soyuka]

Do you have a full stack trace for me?

[teohhanhui]

Not for the first case because it's OOM.

For the second case:

https://gist.github.com/teohhanhui/e4fe81e6d3dd55a0094140c789cc74eb

[teohhanhui]

Which wasn't helpful. We need Behat tests for this.

[teohhanhui]

I see that $visiting is only a local variable, so I don't know how that can possibly work for visited tracking.

[soyuka]

Okay managed to reproduce ;).

[teohhanhui]

Yeah, you're missing the crucial part which is the $visited array which must be passed on. 😆