Conversation
github-actions
bot
added
the
t-console
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
valekjo
force-pushed
the
feature/multiple-datasets
branch
from
652317c to
97effac
Compare
|
Preview for this PR was built for commit |
danpoletaev
force-pushed
the
feature/multiple-datasets
branch
from
97effac to
bf23549
Compare
|
Preview for this PR was built for commit |
metalwarrior665
force-pushed
the
feature/multiple-datasets
branch
from
bf23549 to
97effac
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
TC-MO
left a comment
TC-MO
left a comment
There was a problem hiding this comment.
Focused on grammar and file structure now, once those are dealt with I'll do another pass for other issues
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/actor_definition/dataset_schema/multiple_datasets.md
Outdated
Show resolved
Hide resolved
| When the Javascript SDK is used outside of Apify Platform, aliases fallback to names - using alias would be the same as using named dataset. | ||
| There is one difference - when alias is used, the dataset is purged on first access (if the default dataset should be purged). | ||
|
|
||
| The Python SDK behaves slightly differently, it uses the [aliasing mechanism](https://crawlee.dev/python/docs/guides/storages#named-and-unnamed-storages) specific to Python SDK. Aliases are created as unnamed, but also purged on Actor start. |
There was a problem hiding this comment.
Grammar fix & also we are talking about Apify Python SDK specifically yet linking to Crawlee?
| The Python SDK behaves slightly differently, it uses the [aliasing mechanism](https://crawlee.dev/python/docs/guides/storages#named-and-unnamed-storages) specific to Python SDK. Aliases are created as unnamed, but also purged on Actor start. | |
| The Python SDK behaves differently, it uses the [aliasing mechanism](https://crawlee.dev/python/docs/guides/storages#named-and-unnamed-storages) specific to Python SDK. Aliases are created as unnamed, but also purged on Actor start. |
There was a problem hiding this comment.
True, changing to "uses the aliasing mechanism specific to Crawlee for Python"
|
|
||
| ### Run Storages tab | ||
|
|
||
| The Storage tab of Actor run view is displaying all the dataset defined by Actor and datasets that were used by the run (up to some limit). |
There was a problem hiding this comment.
Some limit is pretty vague, can we offer anything more concrete here?
| The Storage tab of Actor run view is displaying all the dataset defined by Actor and datasets that were used by the run (up to some limit). | |
| The Storage tab of Actor run view displays all datasets defined by the Actor and datasets that were used by the run (up to some limit). |
There was a problem hiding this comment.
Changing to "up to 10 runs"
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
|
Preview for this PR was built for commit |
|
@TC-MO Thanks! I should have caught the "the"s and JavaScripts etc. |
|
Preview for this PR was built for commit |
|
@valekjo no worries! A lot of those can be now caught using our review skill for Claude-code (we might enhance them to be agent agnostic, but for now it's Claude-centric) |
|
I'll make another pass that focus more on the doc itself later today instead of low-hanging fruits |
3 participants
The feature is now supported in both SDKs and API docs is out - we can finally publish the respective section in docs :)