build: reenable GeneratePackageOnBuild#449
Merged
laolubenson merged 1 commit intoappium:masterfrom Jan 14, 2021
Merged
Conversation
Collaborator
Author
|
@mykola-mokhnach This reverts a change I made in the last PR. Unable to test this before merging unfortunately |
mykola-mokhnach
approved these changes
Jan 14, 2021
mykola-mokhnach
left a comment
mykola-mokhnach
left a comment
There was a problem hiding this comment.
I think it would make sense to leave a comment why this should not be changed
This was referenced Jul 23, 2025
This was referenced Aug 5, 2025
This was referenced Oct 7, 2025
This was referenced Oct 24, 2025
This was referenced Nov 12, 2025
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Project file
Details
Reenabled the GeneratePackageOnBuild property because the release github action looks for a generated package for it to publish.
The file version is still removed so the assembly and package should not show an outdated version