Upgrade checkstyle #802
Merged
Upgrade checkstyle #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * or {@link org.openqa.selenium.WebElement} or | ||
| * {@link io.appium.java_client.pagefactory.Widget} or some other user's | ||
| * extension/implementation. | ||
| * Creates field decorator based on serach {@code context} and timeout {@code duration}. |
Member
There was a problem hiding this comment.
should be SearchContext
| </module> | ||
| <module name="NeedBraces"/> | ||
| <module name="LeftCurly"> | ||
| <property name="maxLineLength" value="100"/> |
Member
There was a problem hiding this comment.
Was it intentionally removed?
Collaborator
Author
There was a problem hiding this comment.
yes, it was deprecated for a long time and finally it was removed in Checkstyle 8.2: checkstyle/checkstyle#3671
| toolVersion = '7.0' | ||
| toolVersion = '8.7' | ||
| configFile = file("$projectDir/google-style.xml") | ||
| showViolations = true |
valfirst
force-pushed
the
upgrade-checkstyle
branch
from
a54b62f to
788c62e
Compare
SrinivasanTarget
approved these changes
Jan 10, 2018
Contributor
|
@SrinivasanTarget I will check it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply