Merged
Conversation
Collaborator
Author
|
I will wait for #321 to merge first, cuz I need to modify the CI infrastructure for this PR. |
5b61536 to
9ab96d8
Compare
* unified configure flags * support editable wheel install * make doxygen-awesome-css a submodule * do not auto-download doxygen * better handle notebook tracking * include notebooks in documentation * refactor documentation build process * adapt github actions to use new doc build scripts
9ab96d8 to
628ffb6
Compare
Contributor
|
Documentation preview: https://applied-material-modeling.github.io/neml2/pr-preview/323 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several structural and configuration changes to the build system, focusing on simplifying the build options, improving Python integration, and updating documentation and notebook handling. The most notable changes are the replacement of the old
runnerand documentation options with a unifiedtoolsoption, improved handling of editable Python wheel installs, and enhanced support for Jupyter notebooks and documentation workflows.Build system and configuration changes:
NEML2_RUNNER,NEML2_PYBIND, andNEML2_DOCoptions withNEML2_TOOLSandNEML2_WHEEL, consolidating utility binaries and Python wheel builds under new options. UpdatedCMakeLists.txtandCMakePresets.jsonaccordingly. [1] [2] [3] [4]Documentation and notebook workflow improvements:
doxygen-awesome-cssand removed internal Doxygen download logic, shifting documentation build processes to external scripts and workflows. [1] [2].gitattributesto disable diff for.ipynbfiles and introduced.jupytext.tomland.pre-commit-config.yamlto synchronize Jupyter notebooks with Markdown using Jupytext. [1] [2] [3]CI workflow updates:
These changes streamline the build and documentation process, improve Python integration, and enhance notebook management for development and CI.