feat(misconf): support for azurerm_network_interface_security_group_association

[Dharma-09]

Description

The network_security_group_id attribute on azurerm_network_interface has been deprecated and removed in newer AzureRM provider versions. The recommended approach is now to associate a Network Security Group (NSG) using the separate azurerm_network_interface_security_group_association resource.

This PR adds support for resolving NSGs attached via the azurerm_network_interface_security_group_association resource when adapting network interfaces in the Azure Terraform parser.

Related issues

• Close feat(misconf): support for azurerm_network_interface_security_group_association #10213
• Discussed in network_security_group_id is deprecated on azurerm_network_interface #10203

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[nikpivkin]

Why add this test for the compute service?

[Dharma-09]

Thanks for your review. Here is my reasoning:
It’s related through the VM adaptation path.

I add compute test because I want to validate the real failing path (VM -> NIC -> NSG association), not just NIC parsing in isolation. We can avoid this test by adding regression test for AZU-0068

• VM adapters (adapt.go (line 145)) read network_interface_ids.
• For each NIC, compute adapter calls network adapter (adapt.go (line 154)) via anetwork.AdaptNetworkInterface.
• Network adapter sets NIC SecurityGroups (adapt.go (line 139)).
• New logic resolves NSG from association resources (adapt.go (line 157)) using:
  azurerm_network_interface_security_group_association.network_interface_id
  and network_security_group_id on that association (adapt.go (lines 186-188))
  • plus legacy inline NIC attribute (adapt.go (line 183)).
  • So even though the fix is in adapt.go, the failing check is on VMs

[nikpivkin]

Thanks! I left one comment.