Revert "fixes version number comparisons (#171)"#175
Draft
jacobtylerwalls wants to merge 1 commit intodev/1.1.xfrom
Draft
Revert "fixes version number comparisons (#171)"#175jacobtylerwalls wants to merge 1 commit intodev/1.1.xfrom
jacobtylerwalls wants to merge 1 commit intodev/1.1.xfrom
Conversation
This reverts commit ab1ff21.
Member
Author
|
(Not mergable until confirmed if the version tuple is going to be restored in all versions.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not very urgent, since 8.1 is coming out soon, but given we added the VERSION tuple back in archesproject/arches@0b5ae19, I figured we can adhere to the pattern that will support dev versions next time?
This reverts commit ab1ff21.