feat: treat query_knowledge_sources results as sensitive by default#4404
feat: treat query_knowledge_sources results as sensitive by default#4404abhinav-m22 wants to merge 25 commits into
query_knowledge_sources results as sensitive by default#4404Conversation
|
Hi @joeyorlando! |
|
@joeyorlando - assigning you as a reviewer since you own the original issue. |
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
There was a problem hiding this comment.
I pushed a few minor changes to platform/backend/src/standalone-scripts/codegen-archestra-mcp-server-docs.ts - you'll just need to rerun pnpm codegen to regenerate the contents here
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
query_knowledge_sources results as sensitive by default
joeyorlando
left a comment
There was a problem hiding this comment.
in terms of "migration", where are the default tool invocation + tool result policies being set/assigned for the query_knowledge_sources tool?
@joeyorlando missed that point. I was leaning on the evaluator's "no policy = untrusted" fallback at evaluation time. Just fixed it in It now ensures default rows in both |
This PR closes a critical prompt-injection and RAG-poisoning escalation path by ensuring that results from the built-in
query_knowledge_sourcestool are treated as sensitive by default.Backend
query_knowledge_sourcesinTrustedDataPolicyModel.evaluateBulkto skip the automatic trust bypass for built-in tools.UI
/api/tools/with-assignmentsto support an explicit inclusion filter for specific built-in tools.query_knowledge_sourcesin the tools table while keeping other infrastructure tools hidden.Docs and Tests
codegen-archestra-mcp-server-docs.tsto reflect the trust exception for this tool in the auto-generated platform documentation.