fix: targeted personal MCP installs#4459
Draft
priyanshu0x wants to merge 1 commit into
Draft
Conversation
joeyorlando
changed the title
joeyorlando
reviewed
May 8, 2026
|
|
||
| - **Personal installations** are owned by one user and are useful when each person needs their own upstream account. | ||
| - **Team installations** are shared with a team and are useful for shared service accounts or team-owned integrations. | ||
| - **Organization installations** are shared across the organization and require MCP server installation admin permission. |
Contributor
There was a problem hiding this comment.
require MCP server installation admin permission.
I would document the explict <resource>:<action> permission here instead
joeyorlando
reviewed
May 8, 2026
Contributor
There was a problem hiding this comment.
is similar behaviour allowed through the MCP tool as is now through the API endpoint handler?
Contributor
Author
|
@joeyorlando I am reviewing it myself. I will mark it ready when done. |
priyanshu0x
force-pushed
the
fix/mcp-server-target-user-installs
branch
from
062eade to
f6a1843
Compare
priyanshu0x
force-pushed
the
fix/mcp-server-target-user-installs
branch
from
f6a1843 to
d111689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/mcp_serverpersonal installs to target another organization member viauserIdwhen the caller hasmcpServerInstallation:admin.userIdis omitted.userIdon non-personal installs and document the API behavior.Root Cause
The install route accepted
userIdin the schema but overwrote bothownerIdanduserIdwith the authenticated request user. That made admin pre-provisioning for another user impossible and caused duplicate detection and tool assignment to resolve against the API key owner instead of the intended personal installation owner.Fixes #4452