Allow using mbed pin names and external defines#27
Merged
Conversation
|
Memory usage change @ 8216529
Click for full report table
Click for full report CSV |
|
This should fix #9 and arduino-libraries/Arduino_MachineControl#85, isn't it? |
Contributor
Perhaps "mitigate", but no I wouldn't say "fix". The reason is that it is not really feasible for the average user to set a global definition for the This is something boards platform authors can do with ease, but it is likely only a few very specific 3rd party platforms might do that, especially considering it is undocumented. Advanced users can do it, but even for them it will not be convenient. |
Collaborator
|
@facchinm LGTM. Please, merge and release a new version! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.