while (Monitor.read() != -1) {} hangs#51
Merged
eigen-value merged 1 commit intoarduino-libraries:mainfrom Feb 3, 2026
Merged
Conversation
As I mentioned in the ArduinoCore-zephyr issues: arduino/ArduinoCore-zephyr#320 A sketch that does that will hang as Monitor.read() when the queue is empty returns 0 not -1, as specified in the Stream class https://docs.arduino.cc/language-reference/en/functions/communication/stream/streamRead/
|
Memory usage change @ 316e042
Click for full report table
Click for full report CSV |
eigen-value
approved these changes
Feb 3, 2026
Collaborator
eigen-value
left a comment
eigen-value
left a comment
There was a problem hiding this comment.
@KurtE Thank you for spotting it!
The fix LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I mentioned in the ArduinoCore-zephyr issues:
arduino/ArduinoCore-zephyr#320
A sketch that does that will hang as Monitor.read() when the queue is empty returns 0 not -1, as specified in the Stream class
https://docs.arduino.cc/language-reference/en/functions/communication/stream/streamRead/