fix: make app failed if a container is stopped

[giulio93]

Motivation

If at least a container of an application is stopped due to any reason, the application status should be failed.
In this way even if other containers are up and running the state of the application state is set as failed, and the user can debug the failed container.

[lucarin91]

we should think of some test for this

[lucarin91]

we should add a test for the new check

[giulio93]

Created as status failed!
i've also added statusMessage string example inspired by some real cases

[lucarin91]

We should account for all exit codes that aren't signals, so everything that is less than 128

If you write an app with Python-like

exit(1)

You say that this isn't a fail, which in fact it is, because the app exits right after be started.

[lucarin91]

Why don't you update this mapping function and don't account for the status message there? If a container exited with anything that isn't 128 + 9 we could consider that a failing state, because it means that the process exited without Docker killing it.

[lucarin91]

As I said in a previous review

Why don't you update this mapping function and don't account for the status message there? If a container exited with anything that isn't 128 + 9 we could consider that a failing state, because it means that the process exited without Docker killing it.

I would like to move the parsing function checkExitCode to the StatusFromDockerState mapping function. I think it is clearer to have a single function for mapping docker container status to our app status, instead of adding a special check here.

[giulio93]

https://github.com/arduino/arduino-app-cli/pull/116/files#diff-6fe2dade2880e479db573af3bd075e48246ad3683231b5b2cd44d8341145751c

[giulio93]

I've finally change it to a check bool function, that parse and check that the code is grater than 128, so we now if it was killed or it failed

[lucarin91]

I am not sure which is the meaning of checkExitCode. I would rename this function to

Suggested change

	func checkExitCode(statusMessage string) bool {
	func parseExitCode(statusMessage string) (int, error) {

And use it above in the following way

    if code, err := parseExitCode(statusMessage); err != nil {
         slog.Warn("Failed to parse exit code from status message", slog.String("statusMessage", statusMessage), slog.String("error", err.Error())
    } else if code >= 0 && code < 128 {
		    return StatusFailed
    } 
    return StatusStopped

[lucarin91]

It seems that 128 should be included, i.e., https://tldp.org/LDP/abs/html/exitcodes.html. If we want to consider a failing status, everything that isn't a signal that should include 128, signals start from 128+n, and the signal number cannot be 0.