feat: report status update failure in status#965
Open
crenshaw-dev wants to merge 2 commits intoargoproj-labs:mainfrom
Open
feat: report status update failure in status#965crenshaw-dev wants to merge 2 commits intoargoproj-labs:mainfrom
crenshaw-dev wants to merge 2 commits intoargoproj-labs:mainfrom
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 50.69% 50.83% +0.14%
==========================================
Files 51 51
Lines 5494 5526 +32
==========================================
+ Hits 2785 2809 +24
- Misses 2408 2411 +3
- Partials 301 306 +5 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the need for this enhancement while fixing: #964
The status field validation error was reported only in logs. If we instead stored it in the ready condition on the status, the failure would be available in the Argo CD UI.