fix: test Procfile #11075
Conversation
Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
Codecov ReportBase: 47.78% // Head: 45.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11075 +/- ##
==========================================
- Coverage 47.78% 45.60% -2.19%
==========================================
Files 246 237 -9
Lines 41944 28914 -13030
==========================================
- Hits 20045 13185 -6860
+ Misses 19898 13913 -5985
+ Partials 2001 1816 -185
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
left a comment
There was a problem hiding this comment.
Thanks @patrickbardo! Can you make the same changes to the Procfile in the root of the repo?
Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
|
@crenshaw-dev Updated :) |
ishitasequeira
left a comment
There was a problem hiding this comment.
LGTM!
@crenshaw-dev PTAL
|
@patrickbardo can you fix the conflicts? Sorry for the long delay, we have an overwhelming amount of PR's coming in. Thank your for your patience. |
Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
|
@34fathombelow no worries on the delay, totally understand :) conflicts fixed |
* fix: Procfile Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> * Update root Procfile to be POSIX compliant Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> --------- Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
* fix: Procfile Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> * Update root Procfile to be POSIX compliant Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> --------- Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant
Signed-off-by: Patrick Bardo 76942752+patrickbardo@users.noreply.github.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: