Skip to content

fix: test Procfile #11075

Merged
crenshaw-dev merged 4 commits intoargoproj:masterfrom
patrickbardo:master
Mar 1, 2023
Merged

fix: test Procfile #11075
crenshaw-dev merged 4 commits intoargoproj:masterfrom
patrickbardo:master

Conversation

@patrickbardo
Copy link
Contributor

Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant

Signed-off-by: Patrick Bardo 76942752+patrickbardo@users.noreply.github.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 47.78% // Head: 45.60% // Decreases project coverage by -2.19% ⚠️

Coverage data is based on head (302b803) compared to base (d3ff975).
Patch has no changes to coverable lines.

❗ Current head 302b803 differs from pull request most recent head e0b156a. Consider uploading reports for the commit e0b156a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11075      +/-   ##
==========================================
- Coverage   47.78%   45.60%   -2.19%     
==========================================
  Files         246      237       -9     
  Lines       41944    28914   -13030     
==========================================
- Hits        20045    13185    -6860     
+ Misses      19898    13913    -5985     
+ Partials     2001     1816     -185     
Impacted Files Coverage Δ
cmpserver/plugin/plugin.go 49.28% <0.00%> (-29.23%) ⬇️
util/kube/kubectl.go 0.00% <0.00%> (-16.67%) ⬇️
util/git/creds.go 39.87% <0.00%> (-10.45%) ⬇️
applicationset/services/pull_request/github.go 14.00% <0.00%> (-9.95%) ⬇️
cmd/argocd/commands/applicationset.go 7.32% <0.00%> (-9.73%) ⬇️
util/grpc/errors.go 52.54% <0.00%> (-8.33%) ⬇️
util/helm/cmd.go 24.57% <0.00%> (-7.83%) ⬇️
server/notification/notification.go 56.00% <0.00%> (-7.16%) ⬇️
applicationset/generators/pull_request.go 42.85% <0.00%> (-7.15%) ⬇️
util/io/paths.go 68.75% <0.00%> (-7.12%) ⬇️
... and 236 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patrickbardo! Can you make the same changes to the Procfile in the root of the repo?

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
@patrickbardo
Copy link
Contributor Author

patrickbardo commented Nov 1, 2022

@crenshaw-dev Updated :)

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@crenshaw-dev PTAL

@34fathombelow 34fathombelow added the ready-for-review An approver should give a final review and merge the PR label Feb 24, 2023
@34fathombelow
Copy link
Member

34fathombelow commented Feb 24, 2023

@patrickbardo can you fix the conflicts? Sorry for the long delay, we have an overwhelming amount of PR's coming in. Thank your for your patience.

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
@patrickbardo
Copy link
Contributor Author

@34fathombelow no worries on the delay, totally understand :) conflicts fixed

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @patrickbardo!

@crenshaw-dev crenshaw-dev merged commit f54bc6e into argoproj:master Mar 1, 2023
rumstead pushed a commit to rumstead/argo-cd that referenced this pull request Mar 3, 2023
* fix: Procfile

Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>

* Update root Procfile to be POSIX compliant

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>

---------

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* fix: Procfile

Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>

* Update root Procfile to be POSIX compliant

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>

---------

Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants