Skip to content

fix: make verify-kube-connect broken #12676#12677

Closed
adamiBs wants to merge 1 commit intoargoproj:masterfrom
adamiBs:fix-make-verify-kube-connect
Closed

fix: make verify-kube-connect broken #12676#12677
adamiBs wants to merge 1 commit intoargoproj:masterfrom
adamiBs:fix-make-verify-kube-connect

Conversation

@adamiBs
Copy link
Contributor

@adamiBs adamiBs commented Mar 1, 2023

Fixes #12676.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: adamibs <bsadambs@gmail.com>
@34fathombelow
Copy link
Member

Thanks for submitting this PR. The .dockerignore file was recently changed, there is already a fix for this in #12640 . The updated dockerfile in this PR should be resolved already by your prior PR #12623 .

@34fathombelow
Copy link
Member

@adamiBs I have confirmed make verify-kube-connect works after the recent merges. I believe we can close this PR

@adamiBs
Copy link
Contributor Author

adamiBs commented Mar 2, 2023

I also double checked and it looks like master works correctly.

@adamiBs adamiBs closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make verify-kube-connect broken

2 participants