fix: stop using mixed rxjs versions in Argo CD UI#12685
Merged
alexmt merged 1 commit intoargoproj:masterfrom Mar 2, 2023
Merged
fix: stop using mixed rxjs versions in Argo CD UI#12685alexmt merged 1 commit intoargoproj:masterfrom
alexmt merged 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
commented
Mar 1, 2023
| } | ||
| if (params.get('autoSync') != null) { | ||
| viewPref.autosyncFilter = params | ||
| viewPref.autoSyncFilter = params |
Collaborator
Author
There was a problem hiding this comment.
An old bug which was not noticed due to rxjs version mismatch.
alexmt
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #12685 +/- ##
=======================================
Coverage 47.78% 47.78%
=======================================
Files 246 246
Lines 41944 41944
=======================================
Hits 20045 20045
Misses 19898 19898
Partials 2001 2001
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rumstead
pushed a commit
to rumstead/argo-cd
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rxjs library was upgraded to 7.x in argo-ui but in argocd-ui still uses 6.x. So as a result we are using both version. I cannot explain why build is not failing, but VSCode is showing errors:
PR overrides rxjs version to 6.x (it is not that easy to upgrade to 7.x) which makes VSCode usable again and reduces js bundle size by ~100kb:
before:
after: