Skip to content

feat: Added warning on plugin command returning zero output#12698

Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom
gczuczy:cmpcmd-zerolen-warn
Mar 2, 2023
Merged

feat: Added warning on plugin command returning zero output#12698
crenshaw-dev merged 1 commit intoargoproj:masterfrom
gczuczy:cmpcmd-zerolen-warn

Conversation

@gczuczy
Copy link
Contributor

@gczuczy gczuczy commented Mar 2, 2023 •
edited
Loading

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@gczuczy
Added warning on plugin command returning zero output
49a1ee9 
Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>
@gczuczy gczuczy marked this pull request as ready for review March 2, 2023 15:48
@gczuczy
Copy link
Contributor Author

gczuczy commented Mar 2, 2023

@ishitasequeira Could you please review it?

@gczuczy
Copy link
Contributor Author

gczuczy commented Mar 2, 2023

This PR helps #9029

crenshaw-dev
crenshaw-dev approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gczuczy!

@crenshaw-dev crenshaw-dev merged commit a10fde5 into argoproj:master Mar 2, 2023
rumstead pushed a commit to rumstead/argo-cd that referenced this pull request Mar 3, 2023
@gczuczy @rumstead
feat: Added warning on plugin command returning zero output (argoproj…
a72d4e6 
…#12698)

Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@gczuczy @yyzxw
feat: Added warning on plugin command returning zero output (argoproj…
bedc671 
…#12698)

Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gczuczy @crenshaw-dev