Skip to content

fix: fix typescript compilation errors and add ts validation in lint#12700

Merged
alexmt merged 1 commit intoargoproj:masterfrom
alexmt:12685-typescript-errors
Mar 2, 2023
Merged

fix: fix typescript compilation errors and add ts validation in lint#12700
alexmt merged 1 commit intoargoproj:masterfrom
alexmt:12685-typescript-errors

Conversation

@alexmt
Copy link
Collaborator

@alexmt alexmt commented Mar 2, 2023

Closes #12687

PR fixes existing typescript errors and added validation to lint action

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested a review from rbreeze March 2, 2023 16:37
Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit 13258e4 into argoproj:master Mar 2, 2023
@alexmt alexmt deleted the 12685-typescript-errors branch March 2, 2023 18:37
rumstead pushed a commit to rumstead/argo-cd that referenced this pull request Mar 3, 2023
…rgoproj#12700)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…rgoproj#12700)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript compilation/transpilation errors in Argo CD UI

2 participants