chore: bump argo-ui version#13836
Conversation
|
@blakepettersson can you check the UI build failure? |
529bd10 to
62524e1
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13836 +/- ##
=======================================
Coverage 49.48% 49.48%
=======================================
Files 256 256
Lines 43847 43841 -6
=======================================
- Hits 21697 21695 -2
+ Misses 19988 19985 -3
+ Partials 2162 2161 -1 ☔ View full report in Codecov by Sentry. |
|
@crenshaw-dev I needed to pin |
We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
62524e1 to
40e7e60
Compare
|
@blakepettersson did you have a chance to spin it up locally, just to make sure there's no obvious breakage? If not, I'll give it a try this evening. Preview environments would be great for this stuff. 🙂 |
|
@crenshaw-dev I did, but feel free to try it out on your end as well.Preview environments would definitely be a good thing. 😄 |
crenshaw-dev
left a comment
There was a problem hiding this comment.
All good, long as one of us checked. Thanks!
crenshaw-dev
left a comment
There was a problem hiding this comment.
All good, long as one of us checked. Thanks!
* fix: update deps We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * build: regenerate lockfile Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: bump argo-ui version Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: update deps We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * build: regenerate lockfile Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: bump argo-ui version Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Bump the argo-ui version to get the version which corresponds with the latest
master, containing argoproj/argo-ui#367.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.