chore: Option to disable sync with replace on API Server level (#21427)#22073
Merged
leoluz merged 2 commits intoargoproj:masterfrom Feb 28, 2025
Conversation
…roj#21427) Closes argoproj#21427 Have a global option to disable sync with replace to prevent usage which can cause mini-crises due to pods going down to min replicas if deployments etc. are getting replaced. If users check the replace option, they'd get an error saying that replace was disabled via configuration. Annotations still override this behavior. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22073 +/- ##
==========================================
+ Coverage 53.53% 55.83% +2.29%
==========================================
Files 342 342
Lines 57111 57119 +8
==========================================
+ Hits 30574 31892 +1318
+ Misses 23946 22594 -1352
- Partials 2591 2633 +42 ☔ View full report in Codecov by Sentry. |
andrii-korotkov-verkada
added
the
ready-for-review
github-project-automation
bot
moved this from Ready for final review
to Done
in Argo CD Review
chzar
pushed a commit
to chzar/argo-cd
that referenced
this pull request
Mar 3, 2025
…roj#21427) (argoproj#22073) Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
kingbj940429
pushed a commit
to kingbj940429/argo-cd
that referenced
this pull request
Mar 4, 2025
…roj#21427) (argoproj#22073) Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
Hapshanko
pushed a commit
to Hapshanko/argo-cd
that referenced
this pull request
Apr 29, 2025
…roj#21427) (argoproj#22073) Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21427
Have a global option to disable sync with replace to prevent usage which can cause mini-crises due to pods going down to min replicas if deployments etc. are getting replaced. If users check the replace option, they'd get an error saying that replace was disabled via configuration. Annotations still override this behavior.
Checklist: