feat: Add json+patch support via templateJSONPatch#24934
Open
gregsidelinger wants to merge 14 commits intoargoproj:masterfrom
Open
feat: Add json+patch support via templateJSONPatch#24934gregsidelinger wants to merge 14 commits intoargoproj:masterfrom
gregsidelinger wants to merge 14 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Generated manifests Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Updated generated files Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Add test suite for utilsIsJSONArray. Update error tests for ApplyTemplateJSONPatch. Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #24934 +/- ##
==========================================
+ Coverage 62.82% 62.84% +0.02%
==========================================
Files 412 412
Lines 55635 55669 +34
==========================================
+ Hits 34951 34986 +35
+ Misses 17352 17348 -4
- Partials 3332 3335 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
…plateJsonPatch Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
…plateJsonPatch Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16800
Adds support for json+patches to Applicaitonsets as a way to deal with templatePatch's limitations when dealing with arrays.
Checklist: