feat: Add health checks for ServiceBinding and ServiceInstance#25007
Merged
crenshaw-dev merged 3 commits intoargoproj:masterfrom Oct 21, 2025
Merged
feat: Add health checks for ServiceBinding and ServiceInstance#25007crenshaw-dev merged 3 commits intoargoproj:masterfrom
crenshaw-dev merged 3 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Dobromir Zahariev <dzahariev@yahoo.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
8 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25007 +/- ##
==========================================
+ Coverage 60.83% 60.91% +0.08%
==========================================
Files 351 351
Lines 60489 60489
==========================================
+ Hits 36796 36846 +50
+ Misses 20767 20726 -41
+ Partials 2926 2917 -9 ☔ View full report in Codecov by Sentry. |
yohanb
pushed a commit
to yohanb/argo-cd
that referenced
this pull request
Oct 21, 2025
…roj#25007) Signed-off-by: Dobromir Zahariev <dzahariev@yahoo.com>
AvhiMaz
pushed a commit
to AvhiMaz/argo-cd
that referenced
this pull request
Nov 3, 2025
…roj#25007) Signed-off-by: Dobromir Zahariev <dzahariev@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add health check for ServiceBinding and ServiceInstance resources managed by sap-btp-service-operator.
The resources can have status type "Succeeded" or "Failed" and for values are one of "True" or "False".
In following 2 cases resource is considered as "Degraded":
In case status is missing the resource it is considered as "Progressing"
In case observed generation did not match the current generation the resource it is considered as "Progressing"
In case resource is marked for deletion the resource it is considered as "Progressing"
And in all other cases it is considered as "Healthy"
Verified:

Checklist:
Replacing: #24928