Skip to content

feat: Add health checks for ServiceBinding and ServiceInstance#25007

Merged
crenshaw-dev merged 3 commits intoargoproj:masterfrom
dzahariev:SVCBNDRB
Oct 21, 2025
Merged

feat: Add health checks for ServiceBinding and ServiceInstance#25007
crenshaw-dev merged 3 commits intoargoproj:masterfrom
dzahariev:SVCBNDRB

Conversation

@dzahariev
Copy link
Contributor

@dzahariev dzahariev commented Oct 20, 2025

Add health check for ServiceBinding and ServiceInstance resources managed by sap-btp-service-operator.

The resources can have status type "Succeeded" or "Failed" and for values are one of "True" or "False".
In following 2 cases resource is considered as "Degraded":

  • (Succeeded:False)
  • (Failed:True)

In case status is missing the resource it is considered as "Progressing"
In case observed generation did not match the current generation the resource it is considered as "Progressing"
In case resource is marked for deletion the resource it is considered as "Progressing"
And in all other cases it is considered as "Healthy"

Verified:
501315441-4a0a53d5-3cf3-46e8-8be5-0dffcf76ef0f

Checklist:

  • (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Replacing: #24928

Signed-off-by: Dobromir Zahariev <dzahariev@yahoo.com>
@dzahariev dzahariev requested a review from a team as a code owner October 20, 2025 10:09
@bunnyshell
Copy link

bunnyshell bot commented Oct 20, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.91%. Comparing base (b8f5299) to head (4996f0c).
⚠️ Report is 410 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25007      +/-   ##
==========================================
+ Coverage   60.83%   60.91%   +0.08%     
==========================================
  Files         351      351              
  Lines       60489    60489              
==========================================
+ Hits        36796    36846      +50     
+ Misses      20767    20726      -41     
+ Partials     2926     2917       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev merged commit 51c9add into argoproj:master Oct 21, 2025
28 checks passed
yohanb pushed a commit to yohanb/argo-cd that referenced this pull request Oct 21, 2025
…roj#25007)

Signed-off-by: Dobromir Zahariev <dzahariev@yahoo.com>
@dzahariev dzahariev deleted the SVCBNDRB branch October 30, 2025 14:32
AvhiMaz pushed a commit to AvhiMaz/argo-cd that referenced this pull request Nov 3, 2025
…roj#25007)

Signed-off-by: Dobromir Zahariev <dzahariev@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments