Skip to content

feat(actions): add pause action for KEDA ScaledObject and ScaledJob (#25301)#25302

Merged
reggie-k merged 6 commits intoargoproj:masterfrom
rickbrouwer:keda-paused
Nov 30, 2025
Merged

feat(actions): add pause action for KEDA ScaledObject and ScaledJob (#25301)#25302
reggie-k merged 6 commits intoargoproj:masterfrom
rickbrouwer:keda-paused

Conversation

@rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Nov 16, 2025

This PR adds resource actions for KEDA ScaledObject and ScaledJob:

  • 'Pause' action adds annotation autoscaling.keda.sh/paused=true (both ScaledObject and ScaledJob)
  • 'Paused-Replicas' action adds annotation autoscaling.keda.sh/paused-replicas: “" (only ScaledObject)
  • 'Resume' action removes the annotation
image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [n/a] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [n/a] Does this PR require documentation updates?
  • [n/a] I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [n/a] Optional. My organization is added to USERS.md.
  • [n/a] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes: #25301

@bunnyshell
Copy link

bunnyshell bot commented Nov 16, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@rickbrouwer rickbrouwer force-pushed the keda-paused branch 3 times, most recently from 52b8f4c to bde91e4 Compare November 16, 2025 18:04
@rickbrouwer rickbrouwer changed the title feat: add pause/resume actions for KEDA ScaledObject and ScaledJob (#25301) feat: add pause action for KEDA ScaledObject and ScaledJob (#25301) Nov 16, 2025
@rickbrouwer rickbrouwer force-pushed the keda-paused branch 2 times, most recently from fba6dd8 to 50d3ee3 Compare November 16, 2025 18:55
@rickbrouwer rickbrouwer changed the title feat: add pause action for KEDA ScaledObject and ScaledJob (#25301) feat(actions): add pause action for KEDA ScaledObject and ScaledJob (#25301) Nov 17, 2025
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer changed the title feat(actions): add pause action for KEDA ScaledObject and ScaledJob (#25301) feat(actions): add pause action for KEDA ScaledObject and ScaledJob (#25301) Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.25%. Comparing base (5c6aa59) to head (23dc1ae).
⚠️ Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25302      +/-   ##
==========================================
+ Coverage   62.23%   62.25%   +0.02%     
==========================================
  Files         351      351              
  Lines       49346    49368      +22     
==========================================
+ Hits        30712    30736      +24     
+ Misses      15696    15692       -4     
- Partials     2938     2940       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickbrouwer rickbrouwer marked this pull request as ready for review November 17, 2025 08:25
@rickbrouwer rickbrouwer requested review from a team as code owners November 17, 2025 08:25
@rickbrouwer rickbrouwer marked this pull request as draft November 17, 2025 17:10
@rickbrouwer
Copy link
Contributor Author

rickbrouwer commented Nov 17, 2025

I'm going to set this back to draft. I will add an extra option (paused-replicas).

--

added paused-replicas

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer marked this pull request as ready for review November 17, 2025 19:01
@rickbrouwer rickbrouwer force-pushed the keda-paused branch 3 times, most recently from 6e44faa to ee5dc35 Compare November 18, 2025 18:53
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@JorTurFer
Copy link
Contributor

I think that this could be interesting for you @blakepettersson. IIRC you added some lua configs for KEDA in the past

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer force-pushed the keda-paused branch 3 times, most recently from 5eea595 to cd1b7df Compare November 27, 2025 16:51
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer
Copy link
Contributor Author

rickbrouwer commented Nov 27, 2025

Added discovery tests (advice from @reggie-k)

Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reggie-k reggie-k merged commit a64933f into argoproj:master Nov 30, 2025
28 checks passed
@rickbrouwer rickbrouwer deleted the keda-paused branch December 1, 2025 08:15
FourFifthsCode pushed a commit to FourFifthsCode/argo-cd that referenced this pull request Dec 4, 2025
fsdkibe pushed a commit to fsdkibe/argo-cd that referenced this pull request Dec 5, 2025
yuehaii pushed a commit to yuehaii/argo-cd that referenced this pull request Dec 11, 2025
…rgoproj#25301) (argoproj#25302)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: hai.yue <hai.yue@ingka.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding pause/resume actions for KEDA ScaledObject and ScaledJob

5 participants

Comments