feat(cli): added support for filtering by group in app get-resource CLI command#25495
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
41420b7 to
2875378
Compare
nitishfy
left a comment
There was a problem hiding this comment.
Left a small comment otherwise LGTM!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25495 +/- ##
==========================================
+ Coverage 62.30% 62.58% +0.28%
==========================================
Files 351 352 +1
Lines 49396 49746 +350
==========================================
+ Hits 30775 31135 +360
+ Misses 15684 15628 -56
- Partials 2937 2983 +46 ☔ View full report in Codecov by Sentry. |
reggie-k
left a comment
There was a problem hiding this comment.
Thanks! Can you add some tests for this?
There arent any
Since the new logic that was added is included within the cobra command, there are no existing set of tests that target any of the CLI commands, so I am hesitant to take on establishing such an implementation for a fairly minor enhancement |
Yeah, for unit tests it is true, but we have a lot of existing e2e tests that invoke CLI. |
3e03f09 to
689bd4e
Compare
@reggie-k e2e test has been added |
Signed-off-by: Andrew Block <andy.block@gmail.com>
689bd4e to
6ff9769
Compare
…LI command (argoproj#25495) Signed-off-by: Andrew Block <andy.block@gmail.com> Signed-off-by: hai.yue <hai.yue@ingka.com>
…LI command (argoproj#25495) Signed-off-by: Andrew Block <andy.block@gmail.com>
Resolves #25494