Skip to content

feat(cli): added support for filtering by group in app get-resource CLI command#25495

Merged
reggie-k merged 1 commit intoargoproj:masterfrom
sabre1041:cli-get-resource-group
Dec 8, 2025
Merged

feat(cli): added support for filtering by group in app get-resource CLI command#25495
reggie-k merged 1 commit intoargoproj:masterfrom
sabre1041:cli-get-resource-group

Conversation

@sabre1041
Copy link
Contributor

Resolves #25494

@sabre1041 sabre1041 requested review from a team as code owners December 3, 2025 13:48
@bunnyshell
Copy link

bunnyshell bot commented Dec 3, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@sabre1041 sabre1041 changed the title Added support for filtering by group in app get-resource CLI command feat(cli): added support for filtering by group in app get-resource CLI command Dec 3, 2025
@sabre1041 sabre1041 force-pushed the cli-get-resource-group branch from 41420b7 to 2875378 Compare December 3, 2025 14:02
@sabre1041 sabre1041 requested a review from a team as a code owner December 3, 2025 14:02
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment otherwise LGTM!

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.58%. Comparing base (b5f75f1) to head (6ff9769).
⚠️ Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/app_resources.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25495      +/-   ##
==========================================
+ Coverage   62.30%   62.58%   +0.28%     
==========================================
  Files         351      352       +1     
  Lines       49396    49746     +350     
==========================================
+ Hits        30775    31135     +360     
+ Misses      15684    15628      -56     
- Partials     2937     2983      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add some tests for this?

@sabre1041
Copy link
Contributor Author

Thanks! Can you add some tests for this?

There arent any

Thanks! Can you add some tests for this?

Since the new logic that was added is included within the cobra command, there are no existing set of tests that target any of the CLI commands, so I am hesitant to take on establishing such an implementation for a fairly minor enhancement

@reggie-k
Copy link
Member

reggie-k commented Dec 4, 2025

Since the new logic that was added is included within the cobra command, there are no existing set of tests that target any of the CLI commands, so I am hesitant to take on establishing such an implementation for a fairly minor enhancement

Yeah, for unit tests it is true, but we have a lot of existing e2e tests that invoke CLI.

@sabre1041 sabre1041 force-pushed the cli-get-resource-group branch 2 times, most recently from 3e03f09 to 689bd4e Compare December 8, 2025 13:31
@sabre1041
Copy link
Contributor Author

Since the new logic that was added is included within the cobra command, there are no existing set of tests that target any of the CLI commands, so I am hesitant to take on establishing such an implementation for a fairly minor enhancement

Yeah, for unit tests it is true, but we have a lot of existing e2e tests that invoke CLI.

@reggie-k e2e test has been added

Signed-off-by: Andrew Block <andy.block@gmail.com>
@sabre1041 sabre1041 force-pushed the cli-get-resource-group branch from 689bd4e to 6ff9769 Compare December 8, 2025 15:06
@reggie-k reggie-k merged commit f866959 into argoproj:master Dec 8, 2025
42 of 43 checks passed
yuehaii pushed a commit to yuehaii/argo-cd that referenced this pull request Dec 11, 2025
…LI command (argoproj#25495)

Signed-off-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: hai.yue <hai.yue@ingka.com>
Elyytscha pushed a commit to WhizUs/argo-cd that referenced this pull request Dec 12, 2025
…LI command (argoproj#25495)

Signed-off-by: Andrew Block <andy.block@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter app get-resource command by API group

4 participants

Comments