Skip to content

feat(health): add grafana-org-operator Health#25662

Merged
reggie-k merged 1 commit intoargoproj:masterfrom
sathieu:grafana-org-operator-health
Dec 15, 2025
Merged

feat(health): add grafana-org-operator Health#25662
reggie-k merged 1 commit intoargoproj:masterfrom
sathieu:grafana-org-operator-health

Conversation

@sathieu
Copy link
Contributor

@sathieu sathieu commented Dec 15, 2025

Health for https://gitlab.com/kubitus-project/grafana-org-operator/

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@sathieu sathieu requested a review from a team as a code owner December 15, 2025 13:37
@bunnyshell
Copy link

bunnyshell bot commented Dec 15, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@sathieu sathieu force-pushed the grafana-org-operator-health branch from c4c2a9a to e0b23bb Compare December 15, 2025 13:38
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO just in time for 3.3 thanks hope it works! 😁

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) December 15, 2025 13:39
auto-merge was automatically disabled December 15, 2025 13:39

Head branch was pushed to by a user without write access

@sathieu sathieu force-pushed the grafana-org-operator-health branch from e0b23bb to cde4ce1 Compare December 15, 2025 13:39
@sathieu
Copy link
Contributor Author

sathieu commented Dec 15, 2025

Yes, we use a similar code for months (I refactored a bit).

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) December 15, 2025 13:45
Signed-off-by: Mathieu Parent <math.parent@etik.com>
auto-merge was automatically disabled December 15, 2025 15:28

Head branch was pushed to by a user without write access

@sathieu sathieu force-pushed the grafana-org-operator-health branch from cde4ce1 to 5b12b03 Compare December 15, 2025 15:28
@sathieu
Copy link
Contributor Author

sathieu commented Dec 15, 2025

@crenshaw-dev I had to push again, fixing Test_getHealthScriptPaths. Can you enable auto-merge again?

@reggie-k reggie-k enabled auto-merge (squash) December 15, 2025 15:56
@reggie-k reggie-k merged commit ac1a2f8 into argoproj:master Dec 15, 2025
40 of 42 checks passed
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.61%. Comparing base (125606e) to head (5b12b03).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25662      +/-   ##
==========================================
+ Coverage   62.58%   62.61%   +0.03%     
==========================================
  Files         353      353              
  Lines       50087    50087              
==========================================
+ Hits        31345    31363      +18     
+ Misses      15730    15713      -17     
+ Partials     3012     3011       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sathieu
Copy link
Contributor Author

sathieu commented Dec 15, 2025

Thanks @reggie-k 🙏

Is this missing from the release notes (#25665)?

@reggie-k
Copy link
Member

reggie-k commented Dec 15, 2025

@sathieu yeah, but here is the PR:
#25672

agaudreault pushed a commit to agaudreault/argo-cd that referenced this pull request Dec 16, 2025
Signed-off-by: Mathieu Parent <math.parent@etik.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Jan 16, 2026
Signed-off-by: Mathieu Parent <math.parent@etik.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments