fix(CVEs - cherry-pick-3.1): bump go to 1.25.5 and bump expr to v1.17.7#25890
fix(CVEs - cherry-pick-3.1): bump go to 1.25.5 and bump expr to v1.17.7#25890crenshaw-dev merged 6 commits intoargoproj:release-3.1from
1.25.5 and bump expr to v1.17.7#25890Conversation
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: nitishfy <justnitish06@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-3.1 #25890 +/- ##
===============================================
+ Coverage 61.81% 61.82% +0.01%
===============================================
Files 347 347
Lines 48305 48308 +3
===============================================
+ Hits 29859 29866 +7
+ Misses 15559 15553 -6
- Partials 2887 2889 +2 ☔ View full report in Codecov by Sentry. |
|
@nitishfy do we also need to bump the go version in the GH workflows? I think that determines the go version used in tests/linting. So until we bump that it'll be difficult to judge whether the version bump "works." |
Signed-off-by: nitishfy <justnitish06@gmail.com>
|
@crenshaw-dev I forgot to update the go version in gh workflows. I've done it now. Fortunately, other PRs don't have a go upgrade required so we're good to go! |
|
Looks like we also have to upgrade the linter, which may require making some changes to satisfy new lint rules. But we're almost there. At least tests all pass! |
Signed-off-by: nitishfy <justnitish06@gmail.com>
|
@crenshaw-dev how about now? :) |
|
@nitishfy looks like the linter is still unhappy 0_o |
Signed-off-by: nitishfy <justnitish06@gmail.com>
f75c94d to
6ec0a68
Compare
|
The linter is happy now! |
crenshaw-dev
left a comment
There was a problem hiding this comment.
One last small (I think) request, then LGTM!
Signed-off-by: nitishfy <justnitish06@gmail.com>
1.25.5 and bump expr to v1.17.71.25.5 and bump expr to v1.17.7
1.25.5 and bump expr to v1.17.71.25.5 and bump expr to v1.17.7
Related to #25877
Checklist: