Skip to content

chore(appset): basic progressive sync e2e tests#26092

Merged
rumstead merged 18 commits intoargoproj:masterfrom
ranakan19:progressivesynce2e
Jan 30, 2026
Merged

chore(appset): basic progressive sync e2e tests#26092
rumstead merged 18 commits intoargoproj:masterfrom
ranakan19:progressivesynce2e

Conversation

@ranakan19
Copy link
Member

@ranakan19 ranakan19 commented Jan 21, 2026 •
edited
Loading

  • Adds an env var that applicationset controller expects to enable progressive sync to the test procfile
  • progressive sync test suite skipped if the env variable not set
  • pending tests for reverse deletionOrder

closes #25042

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

basic setup for progressive sync e2e tests
47981d7 
Signed-off-by: krana limaDocker <krana-lima-argo@example.com>
@bunnyshell
Copy link

bunnyshell bot commented Jan 21, 2026 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

krana limaDocker and others added 2 commits January 21, 2026 16:41
@ranakan19
lint check
ec15429 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
fix expected ns and finalizers
d963ab6 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19 ranakan19 mentioned this pull request Jan 21, 2026
Open
@ranakan19
add expectation, fix flow for UI observation
485b6fd 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
use make target for progressive sync e2e tests run with env path var,…
0e9e514 
… lint

Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
run progressive sync e2e as part of existing e2e as beta
052fdbc 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
add test case for checking progression, rename expectation function, …
212128b 
…assisted by: claude-code

Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
Add more test cases
564e300 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
remove commented code
a4773ea 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19 ranakan19 changed the title basic setup for progressive sync e2e tests appset(chore): basic progressive sync e2e tests Jan 29, 2026
@ranakan19 ranakan19 changed the title appset(chore): basic progressive sync e2e tests chore (appset): basic progressive sync e2e tests Jan 29, 2026
@ranakan19 ranakan19 changed the title chore (appset): basic progressive sync e2e tests chore(appset): basic progressive sync e2e tests Jan 29, 2026
@ranakan19 ranakan19 marked this pull request as ready for review January 29, 2026 04:53
@ranakan19 ranakan19 requested review from a team as code owners January 29, 2026 04:53
rumstead
rumstead reviewed Jan 29, 2026
View reviewed changes
rumstead
rumstead reviewed Jan 29, 2026
View reviewed changes
@ranakan19
lint check
988183f 
Signed-off-by: Kanika Rana <krana@redhat.com>
@rumstead
Copy link
Member

rumstead commented Jan 29, 2026

Once the linting errors are fixed and the minor nit about function comments, LGTM.

@ranakan19 ranakan19 requested a review from rumstead January 29, 2026 22:47
rumstead
rumstead reviewed Jan 30, 2026
View reviewed changes
@ranakan19
incorporate ryan's suggestion
bb5affc 
Signed-off-by: Kanika Rana <krana@redhat.com>
@ranakan19
revert newline so no changes in ci-build
b8fb03d 
Signed-off-by: Kanika Rana <krana@redhat.com>
@rumstead rumstead enabled auto-merge (squash) January 30, 2026 15:55
@rumstead rumstead merged commit 989fa6f into argoproj:master Jan 30, 2026
26 checks passed
@pjiang-dev pjiang-dev added the cherry-pick/3.3 Candidate for cherry picking into the 3.3 release label Jan 30, 2026
@argo-cd-cherry-pick-bot
Copy link

argo-cd-cherry-pick-bot bot commented Jan 30, 2026

❌ Cherry-pick failed for 3.3. Please check the workflow logs for details.

argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 30, 2026
@ranakan19 @github-actions
chore(appset): basic progressive sync e2e tests (#26092)
086f3bc 
Signed-off-by: krana limaDocker <krana-lima-argo@example.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
Co-authored-by: krana limaDocker <krana-lima-argo@example.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jan 30, 2026
Merged
Closed
agaudreault pushed a commit that referenced this pull request Feb 12, 2026
@ranakan19 @reggie-k
chore(appset): cherry-pick basic progressive sync e2e tests (#26092) (#…
92df21c 
…26191)

Signed-off-by: krana limaDocker <krana-lima-argo@example.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: krana limaDocker <krana-lima-argo@example.com>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumstead rumstead rumstead approved these changes

Assignees

No one assigned

Labels

cherry-pick/3.3 Candidate for cherry picking into the 3.3 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

e2e tests for progressive sync

3 participants

@ranakan19 @rumstead @pjiang-dev

Comments