Skip to content

ci: exclude testdata from sonar.exclusions#26398

Merged
rumstead merged 1 commit intoargoproj:masterfrom
reggie-k:placate-sonar-with-more-exclusions
Feb 11, 2026
Merged

ci: exclude testdata from sonar.exclusions#26398
rumstead merged 1 commit intoargoproj:masterfrom
reggie-k:placate-sonar-with-more-exclusions

Conversation

@reggie-k
Copy link
Member

@reggie-k reggie-k commented Feb 11, 2026

Sonar is still complaining after the latest fix.
This time it was tested better on a cherry-pick PR to release-3.3 branch - as the Sonar step is not running on PRs from forks.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@reggie-k
exclude testdata from sonar.exclusions
e4b905a 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k requested review from a team as code owners February 11, 2026 12:49
@bunnyshell
Copy link

bunnyshell bot commented Feb 11, 2026 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

nitishfy
nitishfy reviewed Feb 11, 2026
View reviewed changes
nitishfy
nitishfy approved these changes Feb 11, 2026
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rumstead rumstead merged commit 1418e87 into argoproj:master Feb 11, 2026
26 checks passed
@nitishfy nitishfy added the cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch label Feb 12, 2026
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 12, 2026
@reggie-k @github-actions
ci: exclude testdata from sonar.exclusions (#26398)
62aac49 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@argo-cd-cherry-pick-bot argo-cd-cherry-pick-bot bot mentioned this pull request Feb 12, 2026
Merged
@argo-cd-cherry-pick-bot
Copy link

argo-cd-cherry-pick-bot bot commented Feb 12, 2026

🍒 Cherry-pick PR created for 3.2: #26424

reggie-k added a commit that referenced this pull request Feb 12, 2026
@argo-cd-cherry-pick-bot @reggie-k
ci: exclude testdata from sonar.exclusions (cherry-pick #26398 and #2…
1f03b27 
…6371 for 3.2) (#26424)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumstead rumstead rumstead approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees

No one assigned

Labels

cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reggie-k @rumstead @nitishfy

Comments