fix: ensure compatibility of kubeversion.version with what helm reeturns#26469
Conversation
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #26469 +/- ##
==========================================
+ Coverage 62.68% 62.72% +0.03%
==========================================
Files 412 412
Lines 55566 55569 +3
==========================================
+ Hits 34831 34854 +23
+ Misses 17417 17395 -22
- Partials 3318 3320 +2 ☔ View full report in Codecov by Sentry. |
|
|
||
| assert.Equal(t, "v1.30.0", serverVersion) | ||
| assert.NotContains(t, serverVersion, "+", "Should not contain the '+' from Minor field") | ||
| }) |
There was a problem hiding this comment.
All the tests looks good. However, let's add a test for removal of vendor-specific suffixes since this is one of the case normalization targets.
nitishfy
left a comment
There was a problem hiding this comment.
Left a couple of comments, PTAL.
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
|
Thanks for review @nitishfy - I added a comment explaining how Feel free to review again when you have some time |
closes #26330
I used the example chart and app in the original issue to reproduce the problem.
Before the fix the manifest was rendered like this
after the fix it renders as follows.
I think we need to backport this in the supported versions ( 3.3 and 3.2 )
Checklist: