fix: Add X-Frame-Options and CSP headers to Swagger UI endpoints#26521
Open
rohansood10 wants to merge 2 commits intoargoproj:masterfrom
Open
fix: Add X-Frame-Options and CSP headers to Swagger UI endpoints#26521rohansood10 wants to merge 2 commits intoargoproj:masterfrom
rohansood10 wants to merge 2 commits intoargoproj:masterfrom
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Adds X-Frame-Options: DENY and Content-Security-Policy: frame-ancestors 'none' headers to both the Swagger JSON endpoint and the Swagger UI page to prevent clickjacking attacks via iframe embedding. Fixes argoproj#22877 Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
rohansood10
force-pushed
the
fix/22877-x-frame-options
branch
from
d60a6e3 to
40630b6
Compare
Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #26521 +/- ##
==========================================
+ Coverage 62.82% 62.85% +0.03%
==========================================
Files 412 412
Lines 55635 55643 +8
==========================================
+ Hits 34951 34973 +22
+ Misses 17352 17342 -10
+ Partials 3332 3328 -4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22877
The Swagger UI endpoints (
/swagger-uiand/swagger.json) don't set any framing headers, leaving them open to clickjacking via iframe embedding on malicious sites.This adds
X-Frame-Options: DENYandContent-Security-Policy: frame-ancestors 'none'to both endpoints. Both headers are set for defense-in-depth — X-Frame-Options for legacy browser support, CSP for modern browsers.Includes test assertions for the new headers.